search

steamcmd / docker

Docker image containing SteamCMD
https://hub.docker.com/r/steamcmd/steamcmd
MIT License
148 stars 20 forks source link

add ubuntu 22 #62

Closed LsHallo closed 1 year ago

LsHallo commented 1 year ago

I've added ubuntu-22 to the images.
It worked without modification and should be compatible with most repos using ubuntu-20 right now.

LsHallo commented 1 year ago

Hadolint is unhappy. It should also be angry with ubuntu-20 then since I just copied it. Either I consolidate the RUN calls (also for -20, -18 and -16) or we add DL3059 to the hadolint ignore settings.

jonakoudijs commented 1 year ago

Yes, looks good. The codeFactor issue can indeed be fixed by adding the ignore rule to the hadolint config. If memory serves me right I ignored that rule via the CodeFactor app itself a while ago but it probably reset for some reason (or is bound to a repo and is not applied to forks).

The failing build image jobs are because of the "Docker Login" action that is done before the actual test build. Ignore that for now and I will fix these tests in the future.

The only thing left is making sure the following Dockerfiles use the new Ubuntu version as the builder as well to keep it consistent:

Simply change the first FROM line in these 5 Dockerfiles to the following:

FROM steamcmd/steamcmd:ubuntu-22 as builder

If this is added to this PR I will merge it to master.