complete api/Products controller

steamysips / steamy-sips

A full-stack LAMP e-commerce coffee shop.

https://steamysips.github.io/steamy-sips/

Creative Commons Attribution Share Alike 4.0 International

0 stars 0 forks source link

complete api/Products controller #164

Closed Divyeshhhh closed 5 months ago

Divyeshhhh commented 5 months ago

Checklist

Confirm you have completed the following actions prior to submitting this PR.

[x] There is an existing issue report for this PR.
[x] This is not a duplicate of an existing pull request.
[x] My pull request is not resolving multiple issues at once.
[x] I have created a feature branch.
[x] My commit messages are detailed.
[x] All of my commits are relevant to the issue.
[x] composer test does not throw any error.

Issue Resolution

Tell us which issue this PR fixes.

This pull request Fixes #113

Additional Information

Successfully run when tested.

[x] GET /api/v1/products
[x] GET /api/v1/products/[id]
[x] GET /api/v1/products/categories
[x] POST /api/v1/products
[x] DELETE /api/v1/products/[id]
[x] PUT /api/v1/products/[id]

creme332 commented 5 months ago

I made a few changes to the code. the code works for delete and get request methods so far.

[x] You should test the API using Postman. Don't simply write code without running it.

Divyeshhhh commented 5 months ago

Methods working when testing :

[x] GET /api/v1/products
[x] GET /api/v1/products/categories

Errors getting when testing for each methods :

[x] GET /api/v1/products/[id]

Having the same functionality as "GET /api/v1/products", it is not filtering by the id.
[x] POST /api/v1/products

"file_get_contents("php://input"); // ! always empty for some reason" :

https://github.com/pimax/fb-messenger-php/issues/6 https://stackoverflow.com/questions/19146984/file-get-contentsphp-input-always-returns-an-empty-string

[x] DELETE /api/v1/products/[id]

[ ] PUT /api/v1/products/[id]

"file_get_contents("php://input"); // ! always empty for some reason" :

https://github.com/pimax/fb-messenger-php/issues/6 https://stackoverflow.com/questions/19146984/file-get-contentsphp-input-always-returns-an-empty-string

creme332 commented 5 months ago

POST /api/v1/product and DELETE /api/v1/products/[id] now work. Try it out and use the cafe_test db when testing API (set PROD_DB_NAME="cafe_test" in .env)

GET /api/v1/products/[id] was always working on my end:

[x] The method for handling PUT /api/v1/products/[id] is wrong because it calls save() method which simply creates a new record.