search

steavy29 / Telegram.Net

Telegram (http://telegram.org) client library implemented in C#.
17 stars 6 forks source link

Add More Methods and update TODO List #21

Closed ghost closed 7 years ago

ghost commented 7 years ago

Add UpdateProfileRequest and Account TODO List

steavy29 commented 7 years ago

Please fix fields naming in request class to use camel case. first_name -> firstName

ghost commented 7 years ago

Fixed.

ghost commented 7 years ago

I think that switching to 4.5 will be useful for everyone. Can you please switch it?

ghost commented 7 years ago

Can you write channel constrгctors and all channels types, etc? I will write method for this.

munrocket commented 7 years ago

I think that switching to 4.5 will be useful for everyone

Strange that somebody was thinking like this. CSharp havn't no one .Net Core 1.1-2.0 library for telegram. Your project could be unique in the world. But i guess you reverted it to 4.5 by advice.

steavy29 commented 7 years ago

At that point of time .net core was just emerging and even no dependencies were available so migrating to lower .net framework version was not a bad idea. Of course, now it makes sense to have it in .net core. This pr was already closed. Please open new issue if you need something.

munrocket commented 7 years ago

I solved my problem thanks! I think it will be beter for your project if you revert it to Core 1.1-2.0. When somebody found you package with name Telegram.Net.Core in NuGet they expect .Net Core dependencies. Also you know that package Telegram.Net has infinite loop in dependencies?

steavy29 commented 7 years ago

It's not on nuget. Didn't know it is there. What you see there is some guy's fork of Telegram.Net. It's just not ready to be published.