search

stec-inc / EnhanceIO

EnhanceIO Open Source for Linux
Other
420 stars 176 forks source link

Fix compilation errors with kernel 3.14 #72

Closed kcgthb closed 10 years ago

kcgthb commented 10 years ago

In 3.14, bi_sector and bi_size were moved into an iterator.

onlyjob commented 10 years ago

Thanks for the helpful patch. However it doesn't work for me as is:

/var/lib/dkms/enhanceio/0+git20130620/build/eio_main.c: In function ‘eio_map’:
/var/lib/dkms/enhanceio/0+git20130620/build/eio_main.c:2614:20: error: ‘struct bio’ has no member named ‘bi_size’
   if (to_sector(bio->bi_size) != dmc->block_size)
                    ^

It is trivial to fix by adding conditional compilation directives around line 2614.

Besides I think that comments noise is unnecessary...

kcgthb commented 10 years ago

I'm sorry I can't find the line you're referring to. See: https://github.com/stec-inc/EnhanceIO/blob/master/Driver/enhanceio/eio_main.c#L2614.

I agree with your remark regarding the comments though, it was probably a little over the top. :)

onlyjob commented 10 years ago

Sorry mate, I had 622375d8533b507e203660925f228f4107f63a22 applied which your patch do not cover. Besides you wouldn't find corresponding line in unpatched 'master' because error shows line number after when your patch is applied. Thanks.