added support back for orchestra/testbench:^6.17

stechstudio / Laravel-PHP-CS-Fixer

Artisan Command for FriendsOfPHP/PHP-CS_Fixer

MIT License

147 stars 28 forks source link

added support back for orchestra/testbench:^6.17 #36

Closed samrook closed 2 years ago

jszobody commented 2 years ago

Is this really necessary since it's only in the require-dev? I'll be using L9 moving forward when working on this locally, I don't mind making testbench v7 a requirement for development at this point. Shouldn't impact anyone who simply is installing the package.

samrook commented 2 years ago

it was just a thought i had after making the PR tbh. i'd be using laravel 9 going forward myself but some may not. especially with LTS being put on hold until the symfony preload issue is resolved. if you wanna close then i'm cool with that

jszobody commented 2 years ago

If this impacted users of the package I'd be all for it. But I'm just bumping testbench to v7 on all our packages for require-dev, going to leave it for now.