search

stechstudio / filament-impersonate

Filament plugin that makes it easy to impersonate your users
271 stars 55 forks source link

Cause gap on Filament Sidebar #54

Closed MarJose123 closed 9 months ago

MarJose123 commented 1 year ago

https://github.com/stechstudio/filament-impersonate/blob/ee92ce42de52561aaf6731390b92846329f58b13/resources/views/components/banner.blade.php#L37C4-L39

    div.fi-layout > aside.fi-sidebar {
        padding-{{ $position }}: var(--impersonate-banner-height);
    }

This line of code cause an issues with the filament sidebar, it create a gap between the sidebar and the impersonate banner.

I'm using the default setup/configuration of the plugin.

image

Disabling the Css it fixed the issue or if the position setting is top then the css will not be applied.

image image

edwink75 commented 1 year ago

I added this code to my theme.css file and that fixed the issue

div.fi-layout > aside.fi-sidebar {
    padding-top: 0px!important;
}
MarJose123 commented 1 year ago

I added this code to my theme.css file and that fixed the issue

div.fi-layout > aside.fi-sidebar {
    padding-top: 0px!important;
}

Yeah, we can have this as temporary fix on our app.css

jvanloey commented 1 year ago

Another option is publishing the views and removing these lines from the code.

dennisoderwald commented 1 year ago

The problem is superficially solved, but when scrolling in a larger table, it occurs again.

V13Axel commented 9 months ago

Should be fixed as of 3.6, just released