search

stechstudio / filament-impersonate

Filament plugin that makes it easy to impersonate your users
271 stars 55 forks source link

fix gap on Filament Sidebar #56

Closed Lupennat closed 9 months ago

Lupennat commented 1 year ago

fix gap on Filament Sidebar

jszobody commented 1 year ago

Thanks for this!

One problem: this banner component is being used in non-Filament apps as well as Filament. I have apps where Filament is for admins only, and clicking impersonate takes me to a Jetstream customer-facing UI, where I have added the banner component to my main layout file.

So we can't change the CSS in ways that breaks this banner in those scenarios. Modifying the html is how this works globally for non-Filament apps.

I wonder if we just need to break out the banner component and have one dedicated for Filament, and one for everything else. It's either that, or this CSS change needs to fix Filament while still leaving the html margin for everything else.

Lupennat commented 1 year ago

OK I understand the problem you highlight.

I made a change to make the css rule active only when included via filament hook, this way the original behavior is preserved.

Lupennat commented 1 year ago

any feedback about last changes?

gexcube commented 1 year ago

+1

danielreales7 commented 1 year ago

Merge?

jszobody commented 9 months ago

Closing this in favor of #61, which has now been merged.