search

stechstudio / laravel-visual-testing

Visual UI screenshot testing with Laravel Dusk using percy.io
MIT License
33 stars 8 forks source link

Support Laravel 6.x #2

Closed mattrabe closed 4 years ago

mattrabe commented 4 years ago

This package currently fails with Call to undefined function STS\VisualTesting\Console\starts_with() when running on Laravel 6+.

Many array and string helpers were removed in Laravel 6, and now have to be called as static class functions. For example: starts_with() is now only Str::startsWith() and array_get() is now only Arr:get().

I found a fork by @alvaxet which addresses at least some of this: https://github.com/alvaxet/laravel-visual-testing/commit/676d3f3e00455d9defa5b8407aa2c489c9fadebe and will be digging a bit deeper starting now...

UPDATE: alvaxet's PR only addresses one of the two helpers in the codebase, so I have created my own fork, fixed both, and opened a PR: #3