search

stechstudio / laravel-visual-testing

Visual UI screenshot testing with Laravel Dusk using percy.io
MIT License
33 stars 8 forks source link

Broken in the last Dusk (6.14) release #5

Closed inventionate closed 3 years ago

inventionate commented 3 years ago

Unfortunately, the latest Dusk release (https://github.com/laravel/dusk/releases/tag/v6.14.0) seems to make this package useless. I hope this can be resolved soon?

Thanks anyway for the helpful visual testing opportunity!

jszobody commented 3 years ago

It looks like it was moving the commands to the boot method that broke it:

https://github.com/laravel/dusk/pull/884/files

This package overrides the Dusk commands, so I probably just need to move mine to the boot method as well. I don't have time to test this out right now, happy to accept a PR if you do. Otherwise should be able to get to it in a few weeks.

inventionate commented 3 years ago

Thanks for the fast reply. Yes, it does seem to be enough to copy the overwriting commands. Unfortunately, I probably don't have time to test this intensively at the moment as well. If I do get around to it, I'll be happy to send a PR.

jszobody commented 3 years ago

Version 2.0 was just tagged. It fixes this issue and only targets Duck 6.* now (hence the major version number). You should be all set.

inventionate commented 3 years ago

Thank you very much!