Don't use "assertArraySubset" in test suite

stecman / symfony-console-completion

Automatic tab-key completion for Symfony console application options, arguments and parameters

MIT License

421 stars 26 forks source link

Don't use "assertArraySubset" in test suite #35

Closed aik099 closed 9 years ago

aik099 commented 9 years ago

Using assertArraySubset method in test suite requires bumping up PHPUnit dependency to 4.4. I'd recommend using another method/method combination for asserting that.

stecman commented 9 years ago

I've kept the PHPUnit version at ~4.4 for now, so closing this. I don't see any harm in using a newer version of phpunit, since unit tests can be easily run using the composer installed version:

$ ./vendor/bin/phpunit