stecman / symfony-console-completion

Automatic tab-key completion for Symfony console application options, arguments and parameters
MIT License
420 stars 26 forks source link

Allow to specify a sudo user #73

Closed nickvergessen closed 6 years ago

nickvergessen commented 7 years ago

Fix #71

@aik099 @stecman

I didn't test the ZSH part, but I recreated my hook for bash with this and it still works Thanks for all your help

stecman commented 6 years ago

@nickvergessen is this something you're wanting to get merged? Looking through the original issue, I still stand by my comment about this being a design/permissions issue in Nextcloud, so I'm inclined to close this PR.

I'd accept a PR that opens the API up a bit for customisation by user-code, but this change is too specific to your use case IMO.

nickvergessen commented 6 years ago

Would have been nice, but i understand your points