search

stecman / symfony-console-completion

Automatic tab-key completion for Symfony console application options, arguments and parameters
MIT License
420 stars 26 forks source link

Allow Symfony4 #79

Closed VolCh closed 6 years ago

VolCh commented 6 years ago

This PR add support symfony-console-completion in projects that use console 4.0.0-BETA1 and(or) PHPUnit 5.7.

It seems safe to add "minimum-stability": "beta" in master, after release it should be removed. Or you can pull the PR in separate branch to use for example "stecman/symfony-console-completion": "dev-symfony4" in composer.json for testing projects with beta without add forking repo to composer.json

VolCh commented 6 years ago

Rewrited tests for use PHPUnit in 6.x style. Tested with 4.8, 5.7 and 6.4

aik099 commented 6 years ago

Tests are failing PHP 5.5, because PHPUnit version on Travis CI isn't the one with support of TestCase polyfill class. Probably, as separate PR, we can install latest compatible PHPUnit version based on PHP version.

VolCh commented 6 years ago

I set the lowest PHPUnit version to 4.8.36 that introduced forward compatible layer.

VolCh commented 6 years ago

https://github.com/stecman/symfony-console-completion/pull/81 - there used the phpunit from require-devs composer section.

aik099 commented 6 years ago

PR merge order:

  1. 81

  2. 80

  3. 79

VolCh commented 6 years ago

Need some more steps on my part to release changes? Or are we waiting for a stable Symfony 4 version?

VolCh commented 6 years ago

Rebases on #81 & #80 to test passing

aik099 commented 6 years ago

@stecman , any updates?

DavertMik commented 6 years ago

@stecman ping? ;)

petrmalina commented 6 years ago

@stecman pretty please?

VolCh commented 6 years ago

@aik099 thanks for advice: restored 5.3. Also added 7.3 (nightly) with allow failures

aik099 commented 6 years ago

Thanks @VolCh .

danemacmillan commented 6 years ago

Since Symfony 4 was released November 30th, are we going to see this merged in?

timoschwarzer commented 6 years ago

+1

route1rodent commented 6 years ago

any chance to get this released as a semver tag? :) thanks