search

stecman / symfony-console-completion

Automatic tab-key completion for Symfony console application options, arguments and parameters
MIT License
420 stars 26 forks source link

Fix shell type detection. #8

Closed pjcdawkins closed 9 years ago

pjcdawkins commented 9 years ago

This addresses #7

The problem is that CompletionCommand defines the --generate-hook option to have an optional value, although the documentation says it can be treated as a flag (with no value). Setting --generate-hook with no value actually has no effect.

stecman commented 9 years ago

Ah right - I just realised I was testing that issue against the wrong version of this module, which is why I wasn't getting the error. I'd prefer not to add another option, but it doesn't look like it's possible to get the behaviour I was after with InputInterface so I'll accept this fix.

stecman commented 9 years ago

Thanks!