search

stecman / symfony-console-completion

Automatic tab-key completion for Symfony console application options, arguments and parameters
MIT License
420 stars 26 forks source link

Bump min symfony/console version to 6.3 #96

Closed balsama closed 1 year ago

balsama commented 1 year ago

502e2699144a0c39ee51271d18bcf57b0202ab43 introduced a breaking change that requires symfony/console:^6.3, but the current symfony/console constraint (~6.0) allows previous versions. Using this package with symfony/console < 6.3 will result in the following error:

Fatal error: Declaration of Stecman\Component\Symfony\Console\BashCompletion\CompletionCommand::mergeApplicationDefinition($mergeArgs = true) must be compatible with Symfony\Component\Console\Command\Command::mergeApplicationDefinition(bool $mergeArgs = true): void

This PR ensures that the minimum compatible version of Symfony Console (6.3) is installed.

stecman commented 1 year ago

Hmm ok, odd - I tested this change for backwards compat and didn't have any issues. Thanks!

balsama commented 1 year ago

Thanks! And thanks for 0.12.2 :)