stedolan / counterexamples

Counterexamples in Type Systems
http://counterexamples.org
372 stars 23 forks source link

Code samples illegible in dark mode on Firefox/Chrome #7

Open purcell opened 3 years ago

purcell commented 3 years ago

Pages like https://counterexamples.org/runtime-misinformation.html apparently adapt to the OS light/dark colour mode: on MacOS in dark mode with Firefox or Chrome, the code snippets are dark text on dark background, and therefore illegible. Curiously, Safari seems okay. Just wanted to let you know - thanks for the resource.

stedolan commented 3 years ago

Hmmm, I think this might be rust-lang/mdbook#1304. I'll try upgrading to a more recent version and see if that fixes it.

purcell commented 3 years ago

Worth a go, but that issue sounds like Firefox only - I feel like if it had affected Chrome too, someone might have noted it there.

stedolan commented 3 years ago

I tried a few different configs / OSes and I can't reproduce this. Do you have a screenshot? Which MacOS / browser version are you running?

purcell commented 3 years ago
Screenshot 2021-06-05 at 13 10 41

Latest Firefox, latest MacOS, dark mode set system-wide.

purcell commented 3 years ago
Screenshot 2021-06-05 at 13 11 59

Latest Chrome on same system.

purcell commented 3 years ago
Screenshot 2021-06-05 at 13 12 49

Safari is fine.