stedolan / crowbar

Property fuzzing for OCaml
MIT License
183 stars 28 forks source link

add or_bad_test #1

Closed yomimono closed 7 years ago

yomimono commented 7 years ago

Feel free to reject, rewrite, rebuke, or revile as you feel is appropriate.

stedolan commented 7 years ago

Are replying, reviewing and recommending options as well?

I like it, but I don't see why it needs two arguments. Would or_bad_test : 'a option -> 'a be simpler?

(Also, it's good that someone other than me wrote this function. I'd be too tempted to name it nonetheless)

yomimono commented 7 years ago

Oh no, I like nonetheless better!

stedolan commented 7 years ago

It is a silly name, though...