Fix nonterminating size policy.

stedolan / crowbar

Property fuzzing for OCaml

MIT License

183 stars 28 forks source link

Fix nonterminating size policy. #18

Closed stedolan closed 6 years ago

stedolan commented 6 years ago

List and List1 now make size decrease
Join still does not have a sensible policy, but Lazy no longer uses it.
Use (size-1)/n instead of size/n in branches (counting branch nodes instead of leaves)

Still needs work to get a good distribution, but this should squash some stack overflows.

stedolan commented 6 years ago

@yomimono this makes ocaml-test-omp say PASS instead of stack overflow (haven't run it for long, though)

yomimono commented 6 years ago

I've rebased (in an identically-named branch on my fork) and am running some ocaml-test-omp tests on a remote cluster with several cores; I'll report back. Thanks!

yomimono commented 6 years ago

It took 19 million execs to find the first stack overflow, or roughly 2 minutes using 5 cores of the fuzzy machine.

stedolan commented 6 years ago

Closed in favour of #21