Closed fpottier closed 6 years ago
Should the name be failf
to match the naming pattern of functions like printf
?
Looks good! If a new name is chosen, I agree with @hcarty that failf
beats ffail
. I think that this is how fail
should always have worked, but I see how changing it now will break some code.
@yomimono you're probably the person with the most code broken by changing fail
(example), what do you think?
I like what the PR does better (both ffail
failf
and fail
, with backward-compatible fail
, unless I misread) and generally like to have convenience functions for shoving strings directly into functions like this one so would prefer to retain fail
for that reason, but it's not a huge burden to adapt to that API change if you'd prefer to drop it.
Hi, I have renamed ffail
to failf
.
Thanks!
pp_option
should be uncontroversial.ffail
seems useful; it works likefail
, but accepts a format string and extra arguments instead of just a string. One might wish to call it justfail
, but that would technically be an incompatible change, because not every string can be safely re-interpreted as a format string.Finally, I propose changing
fail
to not quote/escape the message. This looks nicer.