search

steel / sprockets-derailleur

Speed up Manifest::Compile by forking processes
MIT License
79 stars 33 forks source link

Thread pooling, and Rails 3.2 yaml's #9

Closed soonahn closed 10 years ago

soonahn commented 10 years ago

After running this and groking the code. It seems like you're allocating N number of threads, and then blocking on the last one to return; only then you'll reallocate the threads.

Was this done on purpose as opposed to using a thread pool? Would you be open to this change?

As well, I can't seem to get this to run with a Rails 3.2 manifest.yml. It seems to want to write a manifest.json every time.

steel commented 10 years ago

At the time I needed the quickest and simplest implementation for Ruby 1.8.7.

As for Rails 3.2, I'd checkout issue #1

soonahn commented 10 years ago

Wait, so yes the lack of thread pooling due to time constraint, and not any other reason?

steel commented 10 years ago

Well 1.8 didn't have native threads so forking processes was best I had. I'm not opposed to using a thread pool. Feel free to fork away.