search

steel97 / veil_wallet

Veil mobile wallet
https://veilproject.org
MIT License
9 stars 5 forks source link

Scan QR code button not working #9

Closed ohcee closed 11 months ago

ohcee commented 11 months ago

Describe the bug When trying to open/press the QR code (left corner) button nothing happens.

Expected behavior QR code to address appears on screen.

Screenshots scan qr button doesn't work

Desktop:

steel97 commented 11 months ago

QR code scanning is unsupported on desktop platforms (it's grayed out to show that). I can remove it, but UI would not look as good as with that button (even if it's grayed out)

ohcee commented 11 months ago

Understood. Personally I would remove it if it does not work, due to it might confuse users into thinking that it should be working and its not (like it did me lol).

steel97 commented 11 months ago

Looks reasonable, will leave issue open, while thinking. Thanks!

ohcee commented 11 months ago

Was thinking maybe just a note when the user is hovering above the greyed out area would be enough. Just as hovering now says "Scan QR". Something that just says "Unavailable for desktop version" or something to help the user understand that its not broken.

Just another suggestion.

steel97 commented 11 months ago

Yes, that's seems good solution!

steel97 commented 11 months ago

Done, now tooltip shows that QR scanning is unavailable