search

steelThread / redmon

A web interface for managing redis: cli, admin, and live monitoring
http://steelthread.github.com/redmon/
1.57k stars 127 forks source link

Add alpine based dockerfile #91

Closed aya closed 7 years ago

aya commented 7 years ago

Starting redmon in a docker

amatriain commented 7 years ago

Is having a Dockerfile as part of a gem standard practice? I don't like the idea, I prefer separation of concerns. I think a separate project for a Docker container to launch redmon would be better. Some people (myself included) include redmon as a gem in our app bundles, and I don't need nor want Docker in the mix.

Also if this PR were accepted, any changes in the Dockerfile (e.g. because of a change in Docker API) would require releasing a new version of the gem. That would mean that people that include the gem in our bundles, without using Docker, would see different versions of the gem that are exactly the same. Very confusing.

For whatever it's worth, I think this PR should not be merged, and the Dockerfile moved to a different separate project instead.

steelThread commented 7 years ago

+1