search

steelThread / redmon

A web interface for managing redis: cli, admin, and live monitoring
http://steelthread.github.com/redmon/
1.57k stars 127 forks source link

Use updated way to connect with Redis #98

Closed tylerdiaz closed 2 years ago

tylerdiaz commented 7 years ago

In the commit https://github.com/redis/redis-rb/commit/895cc3211e335a8fd9ba9322cd311c09eea9621f the Redis library deprecated the Redis.connect that this application depends on. Because the Redis dependency doesn't have the version pinned, using the latest version of this application is broken out of the box.

This merge request helps fix that.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-3.3%) to 78.947% when pulling 8fa39f72da9a217e6859bd953067b7cf4507644c on tylerdiaz:master into 7f567f7afcafdeba3b7a5b13bde2423fb385a28d on steelThread:master.

steelThread commented 7 years ago

I should probably do this a little differently. Do you know when this change was made? Should close out v0.0 with #connect and move to v0.1 with some versioning on the dep gems.

tylerdiaz commented 7 years ago

@steelThread The commit itself https://github.com/redis/redis-rb/commit/895cc3211e335a8fd9ba9322cd311c09eea9621f was made 2 years ago, but only went out on v4.0 about two weeks ago: https://github.com/redis/redis-rb/releases/tag/v4.0.0

I agree, updating the version and pinning the deps is the way to go. Want me to close this PR?