Open VadimDor opened 7 years ago
Unfortunately it looks like detect-character-encoding
requires being built on Windows, which is unlikely to succeed on most people's machines.
So far the best I've come up with is running chcp
, and hardcoding this table in as a lookup for the real encoding, since the utility that would give that isn't availabe on Windows unless you've installed the resource kit.
Error messages in console are not readable at some locales. E.g. by russian locale on Windows we have following for "command not found" error:
instead of
The solution were to decode the message first in module sb-exec file index.js:
instead of (e.g. line 41)
The same probably is valid also for stdout (e.g. line 59 there).
To set valid encoding for TextDecoder() is either up to user over API (should be extended) or some package to guess encoding from buffer could be used (e.g. this one https://github.com/sonicdoe/detect-character-encoding ) or first execute some test command on os (e.g. "chcp" on Windows)