search

steelbrain / linter-ui-default

Default UI for the Atom Linter package
MIT License
84 stars 47 forks source link

Tooltips unreadable when using certain themes #609

Closed michaelvickersuk closed 3 years ago

michaelvickersuk commented 3 years ago

Following updating to version 2.3.1 I've observed the tooltip's text color doesn't have sufficient contrast with the background when using certain themes, resulting in an "empty" looking tooltip.

Screenshot below shows Atom 1.53.0 on Ubuntu 18.04.5 LTS, using Atom Dark UI and syntax themes.

image

Other theme combinations such as One Light UI and One Dark Syntax also display a similar behaviour.

image

No errors are shown in the dev tools console when hovering over an error to trigger the tooltip.

Adding the following to my styles.less corrects the issue when using the Atom Dark UI and syntax themes.

#linter-tooltip .linter-message.error {
  color: #fff !important;
}

Maybe related to the changes from #607 :thinking:

aminya commented 3 years ago

Thanks for the report. I fixed it in the new version