search

steelbrain / linter-ui-default

Default UI for the Atom Linter package
MIT License
85 stars 47 forks source link

Missing Fix button and Linter UI Default: Apply All Solutions not working #632

Closed ghost closed 3 years ago

ghost commented 3 years ago

I am trying to use linter-phpcs and overall it looks to be working. The only issue is the Fix button doesn't appear in the tooltips and trying to run Linter UI Default: Apply All Solutions from the command pallete also doesn't do anything.

I am using Atom 1.54.0 on Windows 10.

To be sure that the issue wasn't being caused by another package, I've disabled everything unrelated, but I get the same results. As it stands these are the only community packages I have enabled: image

I've also installed another linter package, linter-csslint to see if the buttons appear there and they don't, which is why I thought this could potentially be this package causing me issues and not one of the language packages.

Here is a screenshot of what I see, the errors show fine both in the gutter and the linter log, there's just no way of automatically fixing them. image

I have taken a look at the dev console in atom and there aren't any errors showing, I've also searched the issues for fix button and can't find anything related.

Any help would be appreciated, from what I can tell I've installed all of the dependancies it asked for, but this may likely be down to user error, so apologies if it is!

aminya commented 3 years ago

Are you sure that the provider (linter-phpcs) supplies fixes?

Here is an example with atom-ide-javascript: image

ghost commented 3 years ago

I'm honestly not sure. Is there a way to check this in their source code? anything I could search for such as a config setting that linter uses?

I'm in the middle of trying to install atom-ide-javascript so that I can try and replicate your example, but it's taking a while! I will reply once I've got it working

ghost commented 3 years ago

I wasn't able to get the same example working as you, for some reason it doesn't flag your example as a warning (Could be down to other linters you have installed? I don't know).

But i did try to make my own example and I still couldn't see a fix button. image

Packages installed:

ghost commented 3 years ago

I managed to set up Eslinter without the atom-ide packages, for some reason enabling atom-ide-base disabled intentions automatically.

After testing eslint, the fix buttons do appear, so it must be related to the linter-phpcs package I am using.

Apologies for wasting your time.

aminya commented 3 years ago

No problem. intentions packages is not actually needed.

The issue is linter-phpcs. Open an issue there