steelbrain / package-deps

Automatically install dependencies for your atom packages
MIT License
59 stars 20 forks source link

Set patch-package as (normal) dependencies #318

Closed ericcornelissen closed 4 years ago

ericcornelissen commented 4 years ago

Closes #317 by setting the patch-package package as a normal dependency instead of a devDependency so that it will always be available in the context of the "postinstall" script (if I'm not mistaken).

steelbrain commented 4 years ago

Thank you so much for fixing this @ericcornelissen This is actually a dev dependency so should be removed from post-install completely. Fixed in https://github.com/steelbrain/package-deps/commit/a64ac22e7b74315221c724c3a7a2425c2c8462c2

Thanks again

ericcornelissen commented 4 years ago

Guessed incorrectly as to what the correct solution was :sweat_smile: Thanks for the quick fix though!