search

steelbrain / package-deps

Automatically install dependencies for your atom packages
MIT License
59 stars 20 forks source link

Cannot read property 'length' of undefined at lib/index.js:930:26 #321

Closed lierdakil closed 4 years ago

lierdakil commented 4 years ago

See title.

Getting this with the following package deps:

  "package-deps": [
    {
      "name": "atom-ide-ui",
      "minimumVersion": "0.13.0"
    }
  ],
lierdakil commented 4 years ago

I think this is the issue: https://github.com/steelbrain/package-deps/blob/c6bf3ee27d03a2e16f1195c126350d3b6a5a3c4c/src/view/atom.ts#L34

lierdakil commented 4 years ago

As far as I can tell, that line should read resolve(ungroupedDependencies)

steelbrain commented 4 years ago

Good catch! And yes you are right, would you like to open a PR?

lierdakil commented 4 years ago

I think this would be easier to fix entirely on your end, considering you need to build and publish anyway. I'm not a big fan of one-line PRs.

steelbrain commented 4 years ago

I recommended that because I wanted you to get the full attribution for identification and fix

This change is a part of v7.0.2