search

steelbrain / package-deps

Automatically install dependencies for your atom packages
MIT License
59 stars 20 forks source link

Use atom.getConfigDirPath #335

Closed aminya closed 3 years ago

aminya commented 3 years ago

Get the atom home which includes the packages folder. Test runners such as atom-jasmine3-runner change this folder in the test env, so we need to install packages in the correct path.

aminya commented 3 years ago

I think I made a mistake here. This is actually the issue of Jasmine 3 runner that should set process.env.ATOM_HOME so apm and all the headless tools know about the path it is using to run the tests.

Currently, it only sets configDirPath which is not what apm uses to detect the installation path.

https://github.com/UziTech/atom-jasmine3-test-runner/blob/abbbf26a4855a8ebc34a393fe1b5e0cf0f4fe3e1/lib/create-runner.js#L156

cc: @UziTech