Graphics - Githubissues

alfardni commented 1 week ago

This pull request includes the following updates:

Favicon Implementation:

Added our selected UCollab logo as the favicon.
Uploaded favicon files to the public directory.
Integrated the favicon in the _document.tsx file for consistent site-wide display.

Navbar Logo Integration:

Replaced the "UCollab" text in the navbar with our chosen logo.
Ensured responsive design compatibility for different screen sizes.
Adjusted image size and format to maintain quality across devices.

Additional Notes:

This PR addresses and resolves issues #65 (Implement Favicon) and #45 (Integrate Logo into Header). -Please review the changes, especially the logo sizing and placement within the navbar, and confirm everything aligns with our brand style.

steelesh commented 1 week ago

Hi @alfardni, a few things:

When running, I got some errors in the web console (see attached):

looks like you added a link to /site.webmanifest that doesn't exist. Not a big deal if you wanted to add one or remove the link. Either should fix the error.
in the navbar, your image source in the header links to "/UCollablogo.png", but in the branch and pr, that file doesn't exist so it's not showing up.

Also, unfortunately there's merge conflicts that have to be resolved before the pr can be merged

thomasza92 commented 1 week ago

This PR needs to be redone from scratch. The new graphics branch is way out of sync with main, being nearly 66 commits behind. I would suggest deleting the current graphics branch and creating a new branch here that is based off main and then implementing your changes.

Although the confusion is probably based on the branch being so far out of sync, just to clarify, _document.tsx is unnecessary. These changes should be made in _app.tsx, which is where the following code should go between the existing <Head> tags:

        <link rel="icon" type="image/png" href="/favicon-96x96.png" sizes="96x96" />
        <link rel="icon" type="image/svg+xml" href="/favicon.svg" />
        <link rel="shortcut icon" href="/favicon.ico" />
        <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png" />
        <meta name="apple-mobile-web-app-title" content="UCollab" />
        <link rel="manifest" href="/site.webmanifest" />

steelesh / UCollab

Graphics #71