steemit / condenser

The greatest application front-end to the Steem Blockchain.
https://steemit.com
505 stars 429 forks source link

Adjectives are inappropriately reused in translation #2351

Open goldibex opened 6 years ago

goldibex commented 6 years ago

From #1929.

A little more explanation:

In some cases we're inappropriately reusing translations for words like "New" where semantically a translation can't follow the English structure. For instance, you can't reuse the translation for "New" between "New Post" and "15 New Messages" for 2 reasons: 1) "new post" is actually an abbreviated command, and 2) in other languages, the form of the word "new" may change depending on whether it's modifying the word "post" or "messages".

Generally speaking, our policy should be never to reuse a translation except semantically. For instance, a whole phrase like "You cannot undo this action" could be reused.


For example: In the top page, this "new" means "new posts".

I want to translate it into "新着" in Japanese.

In Change Password page, this word is also used.

It means "new password", so I want to translate it into "新しい" in Japanese, or to leave it in English. "新着" is unsuitable.

However, in the souce code, these words are defined by same term 'g.new'. https://github.com/steemit/condenser/blob/master/src/app/components/modules/Header.jsx https://github.com/steemit/condenser/blob/master/src/app/components/elements/ChangePassword.jsx

Unless they are used in exactly the same meaning, they should be defined separately.

bnchdrff commented 6 years ago

find translated strings that are reused, and for each of them, if they are semantically different, create unique translated strings

sneak commented 6 years ago

(even if the english version is identical)

bnchdrff commented 6 years ago

this needs more work; i forgot to put in the locale strings for the first component i did (TransferHistoryRow) and it'll take a minute; closing this until i fix that.

bnchdrff commented 6 years ago

darn it i meant to close my PR. this issue is still open.