search

steemit / devportal-tutorials-js

Tutorials for the Developer Portal
MIT License
44 stars 43 forks source link

JS-T: Meta - Update url-parse to the latest version in all tutorials #125

Closed relativityboy closed 5 years ago

relativityboy commented 6 years ago

A security vulnerability was identified in versions of url-parse that we're using.

roboza commented 6 years ago

Results

Currently only libraries that we use appear to be using the url-parse package. I have updated all package-lock.json files to include the latest version. If this is good we can merge the branch otherwise if not we can leave as is. We are not fixed on a specific version of any packages or url-parse so technically if someone runs npm update they will get the latest versions of the packages.Currently only libraries that we use appear to be using the url-parse package. I have updated all package-lock.json files to include the latest version. If this is good we can merge the branch otherwise if not we can leave as is. We are not fixed on a specific version of any packages or url-parse so technically if someone runs npm update they will get the latest versions of the packages.

relativityboy commented 5 years ago

Ok. Given these tutorials do not interact with external sites and that users have full control over the source when running them, we'll keep this as educational.

Perhaps we should delete the package.lock files entirely.