search

steemit / devportal

Steem Platform Developer Documentation.
https://developers.steem.io
MIT License
122 stars 74 forks source link

Smoke test hivemind error check #415

Closed inertia186 closed 4 years ago

inertia186 commented 5 years ago

Smoke tests didn't notice certain problems because, prior to this pull request, it only expects an error key in the json response. Turns out errors were being reported by hivemind in result, when running:

bundle exec rake test:curl[condenser_api]

After applying this PR, the following examples will be visible:

Examples

This example is ok because if you try it, you see a good explanation. Try a different node and it works ...

image

These are fine as well, since it's clear why it's not working:

image

But these are a problem because the parameter signature changed:

image

That last result was reported to @roadscape, which lead to: https://github.com/steemit/hivemind/issues/183

inertia186 commented 5 years ago

It appears that this pull request might depend on how this issue is resolved: https://github.com/steemit/hivemind/issues/182

roadscape commented 4 years ago

@inertia186 could you please test against https://beta-api.steemit.com? It should now be serving proper jsonrpc errors.

inertia186 commented 4 years ago

Tested against beta-api.steemit.com. Hivemind no longer produces response.result.error, so this PR is no longer needed.