env vars - Githubissues

steemit / hivemind

Developer-friendly microservice powering social networks on the Steem blockchain.

MIT License

73 stars 65 forks source link

env vars #47

Closed roadscape closed 6 years ago

roadscape commented 6 years ago

Where to use env vars vs. args?

appbase flag
consistent use of db_url
steemd vs jussi flag

roadscape commented 6 years ago

trail_blocks
max_block_num_diff?

sneak commented 6 years ago

Assume that the only knobs that will be available to a sysadmin will be env vars. Args are only useful for someone manually running from the command line, which should be infrequent.

sneak commented 6 years ago

Reminder: being able to be used without jussi is not a design goal for hivemind.

goldibex commented 6 years ago

i would strongly advise just using configargparser, it handles all this for you, you get flags and env vars together for free

roadscape commented 6 years ago

Current vars:

DATABASE_URL=postgresql://user:pass@localhost:5432/hive
STEEMD_URL=https://api.steemit.com
MAX_WORKERS=1 (recommended to use 1 until #71)
MAX_BATCH=500 (optimal value?)
LOG_LEVEL=INFO

Pending:

TRAIL_BLOCKS (max_diff is redundant; healthy = no more than 1 behind trail)

roadscape commented 6 years ago

TRAIL_BLOCKS=-1 should be a signal to use last_irreversible