Rename SecretKey to PrivateKey

steemit / libcrypto-js

Cryptographic utilities for Steem in Javascript. Zero dependencies.

5 stars 17 forks source link

Rename SecretKey to PrivateKey #3

Closed jnordberg closed 6 years ago

jnordberg commented 6 years ago

Throughout or stack we use PrivateKey, let's be consistent

goldibex commented 6 years ago

sigh

okay, i'll do this

goldibex commented 6 years ago

On second thought @jnordberg , are you sure about this? some thoughts:

private is a reserved word in Javascript, secret is not
sjcl uses secret and this introduces cognitive overhead in maintaining this library

jnordberg commented 6 years ago

steemd, steem-js, dsteem and steem-python all uses private in the key naming. Secret is nice because sk and pk makes sense in local vars :) but i think having consistence outweighs that

goldibex commented 6 years ago

damn you and your thoughtful, rational analysis