search

steemit / steem-js

Steem.js the official JavaScript library for Steem blockchain
https://www.npmjs.com/package/steem
MIT License
472 stars 222 forks source link

revert tapos ref modification #265

Open roadscape opened 6 years ago

roadscape commented 6 years ago

Revert this change once head block lag is resolved: https://github.com/steemit/steem-js/pull/264

roadscape commented 6 years ago

Also, when we can, tx expiration should be set back to 60s: https://github.com/steemit/steem-js/pull/261/files

bonustrack commented 6 years ago

Is this issue still ongoing @roadscape or should we close it?

roadscape commented 6 years ago

@bonustrack ongoing.. the issues are:

1) The optimal balance for tapos security is head_block - n where n is as small as possible while avoiding potential microforks. 2) 10 minute expirations on tx smells like it's covering up some other bug

With regards to (1), the original reason for pushing it further back was due to either nodes being behind (requested blocks not available), or something that prevented client from accessing non-irreversible blocks. And (2) was due to slow p2p propagation issues, IIRC.

The underlying issues seem to be resolved, but fixing these requires thorough QA to ensure the whole stack can handle tighter tolerances again.