Closed cyon1c closed 6 years ago
Some feedback after a cursory look:
__bytes__
methods (instead of renaming to_bytes
) but continue to call them explicitly? could make the intent more clear.future_bytes
explaining the compatibility issue it solvesI've made updates which should address all your comments, @roadscape . @sneak and @john-g-g , how are we addressing the proposed changes for the pipfile?
@john-g-g regarding the updates to the circle.yml
file, it just runs the docker build - so really do the updates need to be in the Dockerfile, not circle.yml
file?
This PR will bring Python 2.7 Support to
steem-python
.Changes roughly fall into 2 broad categories:
Remove Breaking 3.6 Syntax
**
syntax in dict construction.yield from
syntax tofor x in xyz: yield x
.super
updated.Type Compatibility
bytes
is simply an alias forstr
, which caused wide ranging issues. To resolve this, thefuture_bytes
method was added toutils.py
, along with the librarypython-future
. All class methods named__bytes__
have been refactored toto_bytes
and all references in the app tobytes()
has been refactored tofuture_bytes
.utils.py
to call the appropriate function in the form ofto_chr
.Currently,
steem-python
passes all tests (65/65) when run both in Python 2.7 and Python 3.6