Refactor wallet database passphrase "masterpassword" variable

steemit / steem-python

The official Python (3) library for the Steem Blockchain.

https://steem.io

MIT License

154 stars 100 forks source link

Refactor wallet database passphrase "masterpassword" variable #222

Closed cyon1c closed 6 years ago

cyon1c commented 6 years ago

In wallet.py and storage.py, the variable used to encrypt to the wallet file on disk is called masterPassword which is highly confusing. This needs to be refactored.

sneak commented 6 years ago

propose KEP (key encryption passphrase) (KEK, for Key Encryption Key, is in common usage)

sneak commented 6 years ago

We should also probably have an item to verify that the passphrase to key function (called a key derivation function or password based key derivation function (PBKDF)) is something sane and not just a sha256 or somesuch.