steemit / steem-ruby

Steem-ruby is the official Ruby library for the Steem blockchain
MIT License
9 stars 15 forks source link

Need to add "Unknown exception" to retryable mixin #2

Open inertia186 opened 6 years ago

inertia186 commented 6 years ago

BaseError needs to handle Unknown exception in addition to the others.

Note, hivemind is moving away from a whitelist due to maintenance concerns.

AC

inertia186 commented 5 years ago

This whole thing is a bit of a facepalm because the upstream (jussi or something) might respond with ambiguous errors, handled by accurately named error classes.

But which one's which?

I just wanted to clarify, the commit references Steem::UnknownExceptionError but the issue references Steem::UnknownException. The actual error is indeed intended to be Steem::UnknownExceptionError.

The true error is Steem::UnknownExceptionError because it whitelists the error message "Unknown Exception" from upstream. Getting the text "Unknown Exception" from the upstream API is a different situation from getting a new error message that steem-ruby has never encountered before (aka: Steem::UnknownError).

The rule is simple: