Closed sydneyitguy closed 5 years ago
I appreciate the pull request. I think we'll go with #9 instead. I was working on it in parallel but didn't commit it until today.
Your version of the op helpers do not appear to handle :extensions
parameter. Although this is currently unused, we do want to support it if it's ever enabled.
Also, when you do pull requests, it's a good idea to try to stick to the project established coding standards. Your contribution looks like it's functional, but removes whitespace. If you're using atom, I recommend changing this setting:
No worries :) I didn't know you were working on that feature. Yeah I set up auto strip trailing whitespace on git and editor. I'll make sure keep the standard next time.
Thanks for updating the library!
Tested both method on live chain, and they're working.