steemit / steem

The blockchain for Smart Media Tokens (SMTs) and decentralized applications.
https://steem.com
Other
1.95k stars 793 forks source link

All config options should be valid in config file #2068

Open mvandeberg opened 6 years ago

mvandeberg commented 6 years ago

Several config options can only be specified by command line. Unless there is a compelling reason, they should all be able to be specified in the config file.

It has been this way since BitShares. The only reason I can see to do this is to protect admins from themselves. (e.g. adding --replay to the config file and reindexing when they didn't want to). None of the command line only arguments should be enabled by default in the config file.

Any objections?

Gandalf-the-Grey commented 6 years ago

Love to see --replay in config.ini but with possibility to run --replay=off from the command line to override that when needed.