steemit / steem

The blockchain for Smart Media Tokens (SMTs) and decentralized applications.
https://steem.com
Other
1.95k stars 793 forks source link

condenser_api.get_content active_votes reports all reputations as 0 #3240

Open roadscape opened 5 years ago

roadscape commented 5 years ago

From @emre's https://github.com/steemit/hivemind/issues/175:

[...] Steps to reproduce

  • Find a new content (created on yesterday, or today) and call get_content on api.steemit.com.

Example:

curl -s --data '{"jsonrpc":"2.0", "method":"condenser_api.get_content", "params":["emrebeyler", "witness-update-new-infrastructure-projects-and-statement-regarding-recent-incidents"], "id":1}' https://api.steemit.com

Check the active_votes:

"active_votes": [{
        "voter": "kaylinart",
        "weight": 69590,
        "rshares": "291880101717",
        "percent": 10000,
        "reputation": 0,
        "time": "2019-01-19T12:39:45"
    }, {
        "voter": "claudiop63",
        "weight": 411,
        "rshares": 3447378638,
        "percent": 10000,
        "reputation": 0,
        "time": "2019-01-19T12:50:57"
    },
    (...),],

All reputations are reported as 0. [...]


api.steemit.com nodes no longer run follow_api, but they do enable reputation_api. Probably condenser_api.get_content was not updated to leverage data from the new plugin.

mvandeberg commented 5 years ago

Hmmm... It should be working...

https://github.com/steemit/steem/blob/4cbb921e9cc52f949cff0cf8606da9594982fd42/libraries/plugins/apis/condenser_api/condenser_api.cpp#L1991-L1998

Does reputation get returned properly from the reputation API?

roadscape commented 5 years ago

get_active_votes seems to be affected by the same bug;

curl -s --data '{"jsonrpc":"2.0", "method":"condenser_api.get_active_votes", "params":["emrebeyler", "witness-update-new-infrastructure-projects-and-statement-regarding-recent-incidents"], "id":1}' https://api.steemit.com

{"id":1,"jsonrpc":"2.0","result":[{"voter":"eric-boucher","weight":20819,"rshares":"174640542812","percent":5000,"reputation":0,"time":"2019-01-19T15:18:51"},{...

But get_accounts works fine:

curl -s --data '{"jsonrpc":"2.0", "method":"condenser_api.get_accounts", "params":[["eric-boucher"]], "id":1}' https://api.steemit.com

{"jsonrpc":"2.0","result":[{"id":11178,"name":"eric-boucher",..,"reputation":"68501716014905",..

inertia186 commented 5 years ago

Could it just be a jussi cache causing problems again?

VIM-Arcange commented 5 years ago

Could it be related to this issue https://github.com/steemit/steem/issues/3234 ?