steemit / steem

The blockchain for Smart Media Tokens (SMTs) and decentralized applications.
https://steem.com
Other
1.95k stars 790 forks source link

inconsistent reputation due to the conversion #3241

Open economicstudio opened 5 years ago

economicstudio commented 5 years ago

Initially I thought this may be due to the sync delay of hivemind, but interestingly sometimes hivemind rep was higher (i.e., lower makes sense if it's due to the sync delay).

Finally, I realized that it's due to the conversion: https://github.com/steemit/hivemind/blob/dcb177937578b59bd6471e654654532e58adc170/hive/server/condenser_api/cursor.py#L109

That is, hivemind seems not storing the raw reputation value at all in account table: https://github.com/steemit/hivemind/blob/f7a467921678d928a0d94928c811442b8ab80bce/hive/db/schema.py#L40

I agree that log_rep is useful for the front-end, but all front-ends already expect the raw reputation, so for backward compatibility, the raw reputation should be provided anyway. This extra conversion (which cannot be exact) seems unnecessary to me.

In any case, I think it's better to have the extra field of log_rep in addition to the raw rep.

economicstudio commented 5 years ago

Please see my suggestions: [suggestion] Two small yet mighty information that can be powered by Hivemind - followers' SP / rep & rep_log10: followers' SP / rep & rep_log10 Thanks.