steemit / steem

The blockchain for Smart Media Tokens (SMTs) and decentralized applications.
https://steem.com
Other
1.95k stars 790 forks source link

[suggestion] Increase STEEM_MAX_AUTHORITY_MEMBERSHIP #3428

Open economicstudio opened 5 years ago

economicstudio commented 5 years ago

Today I found a very interesting error message from a user who's trying to use my service @scotauto (Steem Scot claim automation service).

Due to the nature of the service, a user need to authorize its posting right to @scotauto, but the user got the following error message: "size <= STEEM_MAX_AUTHORITY_MEMBERSHIP: Authority membership exceeded. Max: 40 Current: 41"

The error message who will get if you've already authorized your posting rights to 40 apps, but trying to authorize it to an additional app.

While I'm not a huge fan of authorizing posting rights to a dapps (personally I strictly avoid it whenever it's possible), we should not limit it unnecessarily either. It's basically a user's choice.

In addition, authorization can be used for multisig operation.

Thus, I suggest increasing it enough so that accounts can use more dapps.

https://github.com/steemit/steem/blob/d37c264147b7d751b7d815db0952b378533bb54c/libraries/protocol/include/steem/protocol/config.hpp#L271

The limit is defined here, so you can simply increase this by changing that number.

Benefits

mvandeberg commented 4 years ago

It is not as simple as increasing the limit. There are aspects to this limit that are handled in stateless code. I think it could be increased, but it needs to be done carefully. Adding this to the backlog as a potential improvement for a future hardfork.