steemit / steem

The blockchain for Smart Media Tokens (SMTs) and decentralized applications.
https://steem.com
Other
1.95k stars 790 forks source link

[cli_wallet] exception: bad_function_call (no default websocket endpoint) #3597

Open Gandalf-the-Grey opened 4 years ago

Gandalf-the-Grey commented 4 years ago

When you start cli_wallet without explicitly stating -s a.k.a. --server-rpc-endpoint which supposed to have default value ( [=arg(=ws://127.0.0.1:8090)] ) you get a confusing error while trying to use any remote command such as info.

Starting cli_wallet with explicitly stating -sws://127.0.0.1:8090 works fine.

mvandeberg commented 4 years ago

Is this on master?

Gandalf-the-Grey commented 4 years ago

Yes, current master (6412e735)

mvandeberg commented 4 years ago

The behavior is intentional. We added the ability for the wallet to do offline signing. We could change how offline signing is enabled, perhaps with an --offline option that ignores the previous default argument. In your opinion, would that be better UX?

Gandalf-the-Grey commented 4 years ago

I saw that, offline signing is cool. :+1: Yes, keeping default behavior the same + --offline seems more intuitive

mvandeberg commented 4 years ago

Will address this before the SMT release.