Sensor Phalanx bugs

[mys]

Combining fleets

Expected behavior

While scanning planet with Sensor Phalanx it is expected to see every single move, that can be scanned. So if there are 4 missions: Attack and triple ACS Attack, every player using phalanx sensor should see all of them.

Actual behavior

In reality, phalanx shows only one ACS Attack from single player. There is no information on other fleets from specific player. Real quantity and type of ships is unknown. That results in misleading information of fleet movements, what is crucial in planning attack or defense and will affect in battle and war.

How to reproduce

Simplest way to reproduce is to start an Attack mission on planet. Then start ACS and send another two fleets to ACS Attack mission to the same target. All that done by one player. Now, anyone can using Sensor Phalanx scan attacked planet.

Recording Of The Bug

Situation 1. Overview preview (overview shows own fleet all movements). 1 Attack and 2 ACS Attack from single player.

Situation 1. Sensor Phalanx screen

Situation 2. Overview preview. 2 Attack and 2 ACS Attack from single player.

Situation 2. Sensor Phalanx screen

Situation 3. Overview and Sensor Phalanx screen. One player Attacks and another joins as ACS Attack.

---

Scanning players on Vacation Mode

Expected behavior

Vacation Mode should disable all interactions with a player turning on this special mode, in specific there should not be a possibility to scan that player using Phalanx.

Actual behavior

Vacation Mode does not protect from using Phalanx on that player. Note that player on Vacation Mode can't have any fleet moving from or to his planets/moons, so the result from that scan is always the same: There are no moving fleets.

How to reproduce

Simply select planet owned by player on Vacation Mode and scan with Phalanx Sensor. As shown below:

Recording Of The Bug

---

Resources are visible

Expected behavior

Phalanx Sensor should allows to see fleets in flight, together with their composition of ships and time of arrival, but you don't see resources that fleets are carrying.

Actual behavior

Phalanx Sensor allows to see exactly how many resources are transported by specific fleet.

How to reproduce

Simplest way to reproduce is to send any type of mission on a planet with additional resources in the load. Now, anyone can using Sensor Phalanx scan attacked planet.

Recording Of The Bug

---

Recycle missions are visible

Expected behavior

Recycle missions can only be visible by scanning with Phalanx planet from where they were sent. So if planet A sends recyclers on Debris Field near planet B, it should not be visible for Phalanx Sensor to spot that mission if it was used on planet B.

Actual behavior

It is possible to see recyclers send on recycle mission on Debris Field near planet, which is scanned by Phalanx Sensor. That way there is a possibility to predict when enemy fleet will attack even before real attack is sent, because players try to synchronize attack with recyclers.

How to reproduce

Simplest way to reproduce that behavior is to send an recycle on Debris Field near planet, then using Phalanx Sensor scan that planet.

Recording Of The Bug

---

https://utopian.io/utopian-io/@desteemy/sensor-phalanx-bugs by @desteemy

• [ ] Combining fleets
• [x] Scanning players on Vacation Mode
• [x] Resources are visible
• [x] Recycle missions are visible

[mys]

Combining fleets

@Qwatayean the ACS fleets are visible fine. But after patch, non-ACS fleets are doubled in the Phalanx view. The matrix view is inverted? (Fleets in rectangle shouldn't be visible)

This line is a reason https://github.com/steemnova/steemnova/blame/a49eb34688e83a178d4fb20acf2b3d68f4eff426/includes/classes/class.FlyingFleetsTable.php#L123

[Qwatayean]

I suspect is problem on rendering table class from flyingfleet table. Probably he is not splitting the cases. As soon I get pc i will address it. (Maybe tonight ill have one to work)

A Sex, 29/06/2018, 19:16, mys notifications@github.com escreveu:

Combining fleets

@Qwatayean https://github.com/Qwatayean the ACS fleets are visible fine. But after patch, non-ACS fleets are doubled in the Phalanx view. The matrix view is inverted? (Fleets in rectangle shouldn't be visible)

[image: image] https://user-images.githubusercontent.com/17079510/42110489-8e5adf22-7be1-11e8-86de-298958a39d22.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/steemnova/steemnova/issues/150#issuecomment-401448776, or mute the thread https://github.com/notifications/unsubscribe-auth/Ai-3t_53lOAca4EAw9rHvUJFn9DTyDayks5uBnz1gaJpZM4TwHnf .

[yamilrh]

ya corrigieron esto?

[mys]

ya corrigieron esto?

Not yet :<

[Qwatayean]

@mys does that look ok now?

[yamilrh]

hay un problema con el código del phalanx y es que no muestra las misiones 4, ni 8 o sea despliegue hacia cualquiera luna y los de reciclar

$where = '(fleet_start_id = :planetId AND fleet_start_type = 1 AND fleet_mission != 4) OR
                      (fleet_end_id = :planetId AND fleet_end_type = 1 AND fleet_mission != 8 AND fleet_mess IN (0, 2))';

por

$where = '(fleet_start_id = :planetId AND fleet_start_type = 1 AND fleet_mission != 0) OR
                      (fleet_end_id = :planetId AND fleet_end_type = 1 AND fleet_mission != 8 AND fleet_mess IN (0, 2))';

De esta forma se ve todo movimiento con el phalanx, que es como debe ser, como esta, si te destruyen la luna, lo normal es que las flotas en ella se desplieguen para tu planeta pero si le tiras phalanx no se ve.

[mys]

@mys does that look ok now?

@Qwatayean, looks good! Does it include @yamilrh code?

[Qwatayean]

No. The first line simply displays transfer (or deploy according to lang file) mission FROM phalanxed planet. Don't know if this is intended.

The second line of code does not make sense (at least to me) because you will see someone else collecting debris to phalanxed planet (if that happens, does not make sense target can not see his own debris being collected).

[yamilrh]

Haber la primera linea de código es como lo tienen ustedes aquí, y ya lo probé si yo despliego mis flotas de mi planeta principal para cualquiera luna, si tu usas phalanx a mi principal no vez la flota... lo cual si deberías verla... la del reciclaje creo que tienes razón, no creo que sea necesario ver tu propio reciclaje jajaja, sorry, mala interpretación mía