steendam / project2

This repository contains the second project for class MICRBIAL 610, which involves calculating the chemical oxygen demand (COD) values from inserted absorbance values.
GNU General Public License v2.0
0 stars 0 forks source link

Evaluation #1

Open pschloss opened 9 years ago

pschloss commented 9 years ago

When I ran your code I got the following error/warning/notsurewhat...

[1] "The date you are trying to enter is already present in the file. Please adjust manually if necessary."

Grade: 47/50

steendam commented 9 years ago

I don't know if you expect any response, and if you don't, simply ignore the email below:)

I entered that error message to warn the user that they are adding information to the text file that is already there, which they should not be doing (hence that is impossible). I thought I removed the corresponding data from the text file, but it must still be there. You can either remove it and then run the code (then you won't have an error message), or change the date you of the data you are converting:)

About the comments:

Anyway, thanks a lot for the semester, I really enjoyed this course:) Happy holidays - Prettige feestdagen! -Caroline

On Wed, Dec 17, 2014 at 8:38 PM, Pat Schloss notifications@github.com wrote:

When I ran your code I got the following error/warning/notsurewhat...

[1] "The date you are trying to enter is already present in the file. Please adjust manually if necessary."

  • Looking at the source code it seems like I miss out on a lot of the functionality of your code from following the commands in the README.
  • Would have been good for the README to actually execute the commands as it would be if you had made it an Rmd file that was converted to an md file.
  • Nice use of testthat package

Grade: 47/50

— Reply to this email directly or view it on GitHub https://github.com/steendam/project2/issues/1.