search

steepleian / weewx-Weather34-archived-08-02-20

Other
0 stars 1 forks source link

WUnderground Daily Forecast alerting is broken #5

Open Leosirth opened 3 years ago

Leosirth commented 3 years ago

Hi,

the WUnderground Daily Forecast alerting is broken: this always show an alert even if no conditions are reported:

image

PR will follow to fix this.

steepleian commented 3 years ago

Hi Francesco, Can I ask you to move this to the weewx-Weather34-development repository please. Unless there is a critical error that requires an immediate fix we always work on the development repository. We have opted to work like this rather than have a development branch. Thank you

Leosirth commented 3 years ago

Hi Ian,

wouldn't be more clear to have all on the same repo? Having a dev repo would split issues and fixes among the two creating confusion. In addition using a template will generate a new repo every time loosing all the history (just my 2 cent).

Honestly I can't spawn a separated environment for testing the dev repo.

steepleian commented 3 years ago

Hi Francesco,

I know it seems a long winded way to do it, but we have had a couple of accidents in the past so that is why it has been split.

What I will do for know as a compromise: -.

I am trying out your changes on my own live server. If all is OK, I will update the development repository manually. The development repository has some updates which we are likely to want to roll in before the next significant update. When that is done, I will create a development branch at the same time and also re-start the change log.

Thanks, Ian

On 30 Jan 2021, at 23:50, Francesco notifications@github.com wrote:

Hi Ian,

wouldn't be more clear to have all on the same repo? Having a dev repo would split issues and fixes among the two creating confusion. In addition using a template will generate a new repo every time loosing all the history (just my 2 cent).

Honestly I can't spawn a separated environment for testing the dev repo.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/steepleian/weewx-Weather34/issues/5#issuecomment-770299458, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMVT7UJHEXYTP3DAQFCYKTS4SLNHANCNFSM4W2MV6OA.

Leosirth commented 3 years ago

Hi Ian,

Sounds good. If you want I can create a PR on dev once you confirm that it's working.

Do you have an idea by when the new version will be created? I'm working on some others enhanchment and if the forecast for the new version isn't too far I can wait for it in order to start pushing on the new branch.

Kind regards,

Il Dom 31 Gen 2021, 01:08 Ian Millard notifications@github.com ha scritto:

Hi Francesco,

I know it seems a long winded way to do it, but we have had a couple of accidents in the past so that is why it has been split.

What I will do for know as a compromise: -.

I am trying out your changes on my own live server. If all is OK, I will update the development repository manually. The development repository has some updates which we are likely to want to roll in before the next significant update. When that is done, I will create a development branch at the same time and also re-start the change log.

Thanks, Ian

On 30 Jan 2021, at 23:50, Francesco notifications@github.com wrote:

Hi Ian,

wouldn't be more clear to have all on the same repo? Having a dev repo would split issues and fixes among the two creating confusion. In addition using a template will generate a new repo every time loosing all the history (just my 2 cent).

Honestly I can't spawn a separated environment for testing the dev repo.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/steepleian/weewx-Weather34/issues/5#issuecomment-770299458>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AEMVT7UJHEXYTP3DAQFCYKTS4SLNHANCNFSM4W2MV6OA .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/steepleian/weewx-Weather34/issues/5#issuecomment-770301321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGDRD5AQXE6APQNDQ3KCMLS4SNQLANCNFSM4W2MV6OA .

steepleian commented 3 years ago

Hi Francesco,

Do you want to e-mail me directly rather than clutter up the issue log with general discussion.

Thanks, Ian

On 31 Jan 2021, at 00:24, Francesco notifications@github.com wrote:

Hi Ian,

Sounds good. If you want I can create a PR on dev once you confirm that it's working.

Do you have an idea by when the new version will be created? I'm working on some others enhanchment and if the forecast for the new version isn't too far I can wait for it in order to start pushing on the new branch.

Kind regards,

Il Dom 31 Gen 2021, 01:08 Ian Millard notifications@github.com ha scritto:

Hi Francesco,

I know it seems a long winded way to do it, but we have had a couple of accidents in the past so that is why it has been split.

What I will do for know as a compromise: -.

I am trying out your changes on my own live server. If all is OK, I will update the development repository manually. The development repository has some updates which we are likely to want to roll in before the next significant update. When that is done, I will create a development branch at the same time and also re-start the change log.

Thanks, Ian

On 30 Jan 2021, at 23:50, Francesco notifications@github.com wrote:

Hi Ian,

wouldn't be more clear to have all on the same repo? Having a dev repo would split issues and fixes among the two creating confusion. In addition using a template will generate a new repo every time loosing all the history (just my 2 cent).

Honestly I can't spawn a separated environment for testing the dev repo.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/steepleian/weewx-Weather34/issues/5#issuecomment-770299458>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AEMVT7UJHEXYTP3DAQFCYKTS4SLNHANCNFSM4W2MV6OA .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/steepleian/weewx-Weather34/issues/5#issuecomment-770301321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGDRD5AQXE6APQNDQ3KCMLS4SNQLANCNFSM4W2MV6OA .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/steepleian/weewx-Weather34/issues/5#issuecomment-770302922, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMVT7T5HWKT266RCCORUTLS4SPLHANCNFSM4W2MV6OA.