search

steevanb / doctrine-read-only-hydrator

Add SimpleObject and ReadOnly hydrators do Doctrine.
GNU General Public License v3.0
57 stars 14 forks source link

[WIP] Add support of inherance type joined #2

Closed jewome62 closed 7 years ago

jewome62 commented 7 years ago

Hello,

I have in my project some entity with inherance type joined And the bundle do not support them now.

When i make this modification, I have the good classname in $return

I have some problems after, but i don't know if it's my mapping which are original or if i make this modification

jewome62 commented 7 years ago

The error is in vendor/steevanb/doctrine-read-only-hydrator/Hydrator/ReadOnlyHydrator.php line 266 [Symfony\Component\Debug\Exception\UndefinedMethodException] Attempted to call an undefined method named "getName" of class "ReflectionType".

but if was same for all ->getName() into this file. PHPStorm say to me the getName don't exist. on ReflectionType http://php.net/manual/en/class.reflectiontype.php

I can use (string) or ->toString() for get the name. I miss something or this was an error ? (If you confirm i correct it in this PR)

steevanb commented 7 years ago

Thanks for the code, it's merged :) You can upgrade to 2.1.3 to get it.

Here is the fix for ReflectionType::getName() : https://github.com/steevanb/doctrine-read-only-hydrator/commit/7cfef64cfc33433eb06b742baf185ce3f5b96174 This method should be public, but in PHP 7.1.0 and 7.1.1, there is a bug, it's protected. This fix is in 2.1.3 too.

Could you tell me how you find this repo ?

jewome62 commented 7 years ago

Hi,

I find this repo with keyword "doctrine read only" on google