steeve / plugin.video.pulsar

Pulsar addon for XBMC/Kodi
http://forum.kodi.tv/showthread.php?tid=200957
Other
544 stars 351 forks source link

Doesn't run on Windows 8.1 profiles with special characters #107

Closed citysushi closed 9 years ago

citysushi commented 9 years ago

I keep getting the "XBMC needs to restart" error when launching Pulsar, after numerous reinstalls. Same PC but other Windows 8.1 profile without "ë" character works fine.

http://pastebin.com/2B9CWqJT

Looks like a problem with special characters within %appdata% folder. Pulsar or Kodi bug? Other components work fine though.

Best regards.

steeve commented 9 years ago

Can you try, in daemon.py line 56-57 from:

    binary_path = os.path.join(binary_dir, binary)
    dest_binary_path = os.path.join(dest_binary_dir, binary)

to

    binary_path = os.path.join(binary_dir, binary).decode("utf-8")
    dest_binary_path = os.path.join(dest_binary_dir, binary).decode("utf-8")
citysushi commented 9 years ago

Thanks for the reply. I tried it, unfortunately no success.

This happens on Kodi startup, not having started the add-on yet: http://pastebin.com/8CLEvbk4

steeve commented 9 years ago

Remove the change I told you, and replace:

    binary_path = os.path.join(binary_dir, binary)
    dest_binary_path = os.path.join(dest_binary_dir, binary)

with

    binary_dir = binary_dir.decode("utf-8")
    dest_binary_dir = dest_binary_dir.decode("utf-8")

    binary_path = os.path.join(binary_dir, binary)
    dest_binary_path = os.path.join(dest_binary_dir, binary)
citysushi commented 9 years ago

Done. Still not working, though it's an other error:

http://pastebin.com/6uBeYii6

NOTICE: UnicodeEncodeError: 'ascii' codec can't encode character u'\xeb' in position 13: ordinal not in range(128)

steeve commented 9 years ago

Try this:

    binary_dir = binary_dir.decode("latin1")
    dest_binary_dir = dest_binary_dir.decode("latin1")

    binary_path = os.path.join(binary_dir, binary)
    dest_binary_path = os.path.join(dest_binary_dir, binary)
steeve commented 9 years ago

Fixed in 6ed4d58f52737bec332348ac8f1fd44054039d40

You should be fine with v0.4.7