search

steeve / plugin.video.pulsar

Pulsar addon for XBMC/Kodi
http://forum.kodi.tv/showthread.php?tid=200957
Other
546 stars 350 forks source link

Feature: Subtitle automatic matching #45

Open nikalexis opened 9 years ago

nikalexis commented 9 years ago

I good feature will be to search for a matched subtitle (via the torrent title) from the subtitles add-on list and download the best match for both the torrent and the subtitle before the selection/start of the stream, so that you can result with a stream that has support for a subtitle.

Great add-on btw!

Magic815 commented 9 years ago

I second this feature request.

In addition, would it be possible to have the Pulsar subtitle service include the ability to seamlessly handle forced subtitles? It seems most streams don't even include the force subtitles, so it would be nice if Pulsar was able to automatically create that link.

steeve commented 9 years ago

I'm not sure what you guys want that's not done by the subtitle provider? Pulsar does already tell you if the sub is synced to the stream

Magic815 commented 9 years ago

Well I don't want to put words in winnerNick's mouth, but for me I was asking if there would be a way for Pulsar to automatically assign a forced subtitle file to the stream that is playing. For instance, it seems like all of the YIFY streams don't contain forced subtitles (for those who use that provider). Check out the Dawn of the Planet of the Apes movie, and watch the first 10 minutes. All of the ape sign-language should have forced subtitles showing, but the YIFY releases don't have them showing.

Because of this, I need to manually search for subtitles after I start playing the stream, and then try to find a "forced subtitles" only file that matches the stream I'm playing.

My thought was this: What if Pulsar could check the entire subtitle list and compare it to the current stream that is playing. Then if it can find a sync'd subtitle option that also says "forced" in it's name, and is also in the language the user selected in their settings (in my case - English (US)). At that point, couldn't it automatically match in the forced subtitles for that stream so that the user doesn't need to do any manual digging themselves everytime?

Obviously all normal subtitle tracks (which are an optional thing that users may or may not want) should stick to the manual method that we currently have. I was just thinking it might be worthwhile to automatically sync in "forced subtitles."

steeve commented 9 years ago

Not impossible, but how would I know that a sub is for forced subs only, and not the whole movie?

Magic815 commented 9 years ago

I've noticed that they'll often times say something along the lines of "english-forced" somewhere in the name. Maybe it would be a simple check for the keyword "forced"? Although I imagine complications would occur if the name of the movie itself already contained the word "forced."

Magic815 commented 9 years ago

It looks like yifysubtitles.com is a website for those releases. I guess they operate a little separately from opensubtitles.org. Would there be any way for the pulsar subtitle service to also pull from there as a start?

It kinda seems like forced subtitles with YIFY releases is a widespread issue. Their own site has people constantly asking/checking for just the forced subtitle version. I'll have to do more digging on if there is any good way to differentiate. It looks like a lot of people call them "non-english only" subtitles - maybe that's what would be searched for in the list of choices by Pulsar?

steeve commented 9 years ago

There's no way I will integrate with yifysubtitles, as this service is for pirate streams. Sorry.

Magic815 commented 9 years ago

@steeve Maybe I should ask the question in a different way. Is there a possibility of handling subtitles in the same way that stream providers get handled? Could the Pulsar subtitle service be written in a way to allow for other devs to write their own "subtitle providers" so that they can pull from other sources?

steeve commented 9 years ago

Ah got it. This is unlikely though, because it is built in the Pulsar core (at least for now).

Also, OpenSubtitles is the only provider that I know of that needs to use movie hashes (to determine sync), so for other providers, you can write regular XBMC subtitle providers.